Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to HTMLUnit 4.1.0 #40765

Merged
merged 1 commit into from
May 22, 2024
Merged

Update to HTMLUnit 4.1.0 #40765

merged 1 commit into from
May 22, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented May 22, 2024 •
edited
Loading

  • This changes the package names and the artifact GA
  • Also fixes CVE-2023-26119

Migration instructions: https://www.htmlunit.org/migration.html

@gastaldi gastaldi requested a review from sberyozkin May 22, 2024 00:08
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/keycloak area/oidc labels May 22, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi gastaldi requested a review from gsmet May 22, 2024 04:42
gsmet
gsmet approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the BOM so this should be safe.

@gastaldi
Update to HTMLUnit 4.1.0
c65d982 
- This changes the package names and the artifact GA
- Fixes CVE-2023-26119
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c65d982.

Failing Jobs

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Failures Logs Raw logs Build scan
✖ Documentation Build Build ⚠️ Check → Logs Raw logs 🚧

@gastaldi
Copy link
Contributor Author

The documentation build is fixed in #40775

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 22, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c65d982.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

⚙️ JVM Tests - JDK 21

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting - History

  • Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true} - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting(HibernateHotReloadTestCase.java:87)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition returned by method "waitForNextCompletion" in class io.quarkus.test.ContinuousTestingTestUtils was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

@gastaldi gastaldi merged commit a2d39ae into quarkusio:main May 22, 2024
53 of 54 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 22, 2024
@gastaldi gastaldi deleted the update_htmlunit branch May 22, 2024 14:49
@sberyozkin
Copy link
Member

Thanks @gastaldi, missed review request yesterday

@sberyozkin sberyozkin mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@sberyozkin sberyozkin Awaiting requested review from sberyozkin

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/keycloak area/oidc triage/flaky-test
Projects
Quarkus Documentation
Status: Done
Milestone
3.12.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@gastaldi @sberyozkin @gsmet